Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting the correct project root from a git submodule's COMMIT_EDITMSG #98

Open
mikavilpas opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@mikavilpas
Copy link
Owner

I use https://github.com/mikavilpas/tsugit.nvim (lazygit) and sometimes work in projects that use git submodules. I want to use blink-ripgrep to write commit messages, so that I can reuse words in my project.

Currently the project root is resolved to the root of the main repo (with the submodules).
There is a performance problem in huge projects that contain many, many submodules.

Instead of resolving the root of the main repo, by default I think the submodule root should be used instead.

/Users/mikavilpas/git/root-repo/.git/modules/sub-repo/COMMIT_EDITMSG

@mikavilpas mikavilpas self-assigned this Jan 9, 2025
@mikavilpas mikavilpas added the enhancement New feature or request label Jan 9, 2025
@mikavilpas
Copy link
Owner Author

Git allows getting the repo root with git rev-parse --show-toplevel. Maybe this can be reused so I don't have to write my own resolution logic.

Copy link

github-actions bot commented Feb 9, 2025

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant