-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using testcontainers in the tests #57
Comments
@roji It's cool! I am new to Testcontainers. I searched for modules on testcontainers.net and found that Milvus in Testcontainers seems to only support Java and Go. However, I noticed that #58 is using it. Is it also available for .NET? Does this imply that we can conveniently test multiple versions of Milvus simultaneously?" |
Unfortunately not - as you've found out, testcontainers modules currently exist only for Java and Go. However, in #58 I implemented such a module, and the plan is to submit that to be a part of testcontainers alongside the existing Java/Go ones. This would enable .NET developers to easily test against Milvus. |
Yeah, this will simplify that. However, I took a look at 2.2, and that version is quite difficult to get running properly (2.3 is much simpler). I think we probably may want to just concentrate on 2.3 going forward - people still targeting 2.2 can use the 2.2 version of the SDK in any case. But future versions can indeed be tested as a test matrix in Github Actions in a pretty easy way using testcontainers. |
Our tests currently rely on an externally available Milvus instance. This makes it a bit harder to contribute, and also complicates our CI.
We can instead use testcontainers.net; note that there already are testcontainer modules for Milvus, but currently only for
The text was updated successfully, but these errors were encountered: