Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array fields #77

Closed
BlackGad opened this issue Apr 15, 2024 · 3 comments · Fixed by #81
Closed

Support array fields #77

BlackGad opened this issue Apr 15, 2024 · 3 comments · Fixed by #81
Labels
enhancement New feature or request
Milestone

Comments

@BlackGad
Copy link
Contributor

Current client API does not allow you to specify field schema for Array types.

I propose extending the C# API to include support for defining array field schemas, which would allow developers to specify the type of elements in the array along with constraints such as capacity and maxLength. Below are proposed methods to add to the API for defining array fields with both varchar and scalar types:

FieldSchema.CreateVarcharArray("field_id", capacity: 200, maxLength: 255, description: "Array of varchars"),
FieldSchema.CreateArray<float>("field_id", capacity: 200, description: "Array of scalar types")
@roji roji added the enhancement New feature or request label Apr 15, 2024
@roji roji added this to the 2.3.1 milestone Apr 15, 2024
@roji
Copy link
Collaborator

roji commented Apr 15, 2024

Thanks. Yeah, the SDK was originally developed against 2.2, and arrays were only introduced against 2.3 - we missed this. We'll take a look at implementing it.

@BlackGad
Copy link
Contributor Author

BlackGad commented Apr 18, 2024

As well as iterators. Crucial thing for our needs. https://milvus.io/docs/with-iterators.md

@BlackGad
Copy link
Contributor Author

BlackGad commented Apr 19, 2024

PR with an Array fields implementation #81
PR that implements Query with an iterator #80

@roji roji changed the title Allow Array fileds in schema Support array fields Apr 21, 2024
@roji roji closed this as completed in #81 Apr 22, 2024
@roji roji closed this as completed in b1bd801 Apr 22, 2024
roji pushed a commit that referenced this issue Apr 22, 2024
Fixes #77

(cherry picked from commit b1bd801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants