Basic changes needed to get tests passing on Milvus 2.3 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roji Thanks! It's a good idea that making main represent the "latest" state. Milvus 2.2 and 2.3 should be compatible, with no breaking changes, but running tests is also a good idea. I would be happy to give you this permission, as you have done most of the work. However, I am a community contributor and do not have administrative rights. Maybe @yhmo can do this, let me try to contact him. |
|
@weianweigan thanks and no problem. In the meantime, feel free to approve and merge this PR - I can do some extra work in the coming weeks for 2.3 etc. |
|
Thanks! You can now also delete the 2.3 branch from this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weianweigan this PR merges the 2.3 branch into main, making main represent the "latest" state, as is standard with git development. In parallel, we can create a hotfix branch for 2.2, in case we want to release a patch version for that as well.
BTW I think we should also look into making the new SDK version (2.3) run against older Milvus versions (2.2); if Milvus itself supports it (i.e. no gRPC schema breaking changes) then it should be possible; we should also add a Github Actions test against Milvus 2.2 in that case.
BTW if you'd like, you can give me repo write access (or triage access), so that I'm able to create a milestone for 2.3, organize issues etc. (I'll continue to wait for your approval before merging etc.).