Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio to allow compilation for Windows ARM arch #3794

Open
ardocrat opened this issue Jun 29, 2024 · 2 comments
Open

Update tokio to allow compilation for Windows ARM arch #3794

ardocrat opened this issue Jun 29, 2024 · 2 comments

Comments

@ardocrat
Copy link

grin-api and grin-servers are using too old tokio-0.2 crate what prevents to compile Grin for Windows ARM (winapi-0.2.8 dependency has no aarch64-pc-windows-msvc target support).

Solution is to migrate to tokio-1.^.

@cekickafa
Copy link
Contributor

@phyro @yeastplume @tromp @hendi @quentinlesceller
Can you have a look at it ?

@yeastplume
Copy link
Member

Just to explain, this requested upgrade isn't just updating a version number and re-building. Tokio is a threading and futures library around which most of the crates in the core project have been built, and it's changed greatly between versions. This is a very large upgrade that needs a lot of code changes, care and extensive testing before it can be integrated.

We may have to look at this and some other aging crates eventually, but for now the effort is going to have to be balanced against the end-result, Windows ARM support might be a nice-to-have but I can't see it as being worth the effort right now given the amount of work it would require to update Tokio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants