Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheel package file format support #3

Closed
mnixry opened this issue Sep 23, 2022 · 3 comments
Closed

Add wheel package file format support #3

mnixry opened this issue Sep 23, 2022 · 3 comments

Comments

@mnixry
Copy link

mnixry commented Sep 23, 2022

Some special runtimes, for example, PyScript only accept wheel format of package.
Since this package is a pure-python implementation, in this case, we can easily build the .whl package by python setup.py bdist_wheel command before you publish.

Anyway, thank you for your continuously maintain this package.

@mina86
Copy link
Owner

mina86 commented Sep 23, 2022

I’m not familiar with PyScript or wheel files so bare with me. How does it help that I have a .whl file in my dist directory? I’m not sure I understand what you’re proposing.

@mnixry
Copy link
Author

mnixry commented Sep 23, 2022

Sorry for my poor explanation

If you have a .whl in your dist directory, it will be released together with .tar.gz in a new version. You can find that in the file panel in PyPI website.

Many of Python packages, are published both .whl and .tar.gz format package in PyPI.
The .whl file indicates it is “Built Distributions” can be installed directly (includes necessary dependencies and metadata).
But the .tar.gz file means it is “Source Distribution” that requires some post-processing steps (For pygtrie, It is execute python setup.py install), almost no differ from pull the code from GitHub and install.

Even if there are pure-python packages, which doesn't need some complex compile steps, we still need to build and upload a .whl file to indicate we have a “Built” distribution with all required metadata. (PyScript only have an over simplified pip implementation, so it can only accept a built distribution)
For example, requests are having both of them.

So I think publishing a package with .whl can not only bring compatibility to PyScript users, but also standardizes the package-publishing process. That will benefit many pygtrie users experiences implicitly.

@mina86
Copy link
Owner

mina86 commented Sep 24, 2022 via email

@mina86 mina86 closed this as completed in 6a322e2 Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants