Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

important resource leak issues #13

Open
NeilChenyc opened this issue Mar 25, 2025 · 1 comment
Open

important resource leak issues #13

NeilChenyc opened this issue Mar 25, 2025 · 1 comment

Comments

@NeilChenyc
Copy link

  • InXMind2MindMapImporter class, thedoImport method created aZipFile object without closing it. This could lead to file handle leaks. I fixed this by implementing a try-with-resources statement to ensure proper closure.
  • Similarly, inNovamind2MindMapImporter class, the same issue existed in itsdoImport method. I applied the same fix using try-with-resources.
@mindolph
Copy link
Owner

Thanks, could you please create a merge request if you have forked and fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mindolph @NeilChenyc