Different param2 of the bed bottom the top causes crash on dig.

[nininik0]

If you change the param2 of the base of the bed to be very or slightly different from the top, maybe param2 tool or some glitch, when dug or removed in any way(tnt, worldedit remover) it causes a crash where "b" is a nil value.

[SmallJoker]

Cannot reproduce. Please provide a backtrace and a screenshot before the error.

[nininik0]

Cannot reproduce. Please provide a backtrace and a screenshot before the error.

It has to be some INSANE value like in the 200s maybe 250s, here is some screenshots

[nininik0]

This bug has been plaguing my server since a bad person got a param2 tool and has several crashing beds hidden, so after he got banned he uses a VPN to ban evade xban2 and digs those beds which is very annoying, I already managed to destroy some of the beds by setting their param2 of the top and bottom with worldedit to 0 and then rotating the bottom properly.

[SmallJoker]

This brings me back to one of my first memories related to Minetest in 0.4.7, where a badly rotated node would cause a client crash on the "Landrush" server which required to download the newer development version, 0.4.7-dev from the forums.

The root cause lies here:
https://github.com/minetest/minetest/blob/f467bde6ac3f906fcb3cf0a7e80b25f4db3beca0/builtin/common/item_s.lua#L75-L94

Only 24 out of the 255 possible values are mapped to a direction. As for the visuals, the engine does use the following calculation:
https://github.com/minetest/minetest/blob/f467bde6ac3f906fcb3cf0a7e80b25f4db3beca0/src/mapnode.cpp#L41-L48

I'll include a fix for this in my other PR.

[appgurueu]

since a bad person got a param2 tool

Out of curiosity, how did this happen?

(Also, have you considered registering the param2tool under a new name, so old param2 tools become unusable; additionally, register old param2tools to something that blows up in his face in some funny way 😄)