fix: leaking response body upon PromptObject() error

harshavardhana · harshavardhana · commit ab1c2fe050a4 · 2024-11-01T17:04:24.000-07:00
diff --git a/api-prompt-object.go b/api-prompt-object.go
@@ -68,10 +68,10 @@ func (c *Client) PromptObject(ctx context.Context, bucketName, objectName, promp
 	if err != nil {
 		return nil, err
 	}
-	if resp != nil {
-		if resp.StatusCode != http.StatusOK {
-			return nil, httpRespToErrorResponse(resp, bucketName, objectName)
-		}
+
+	if resp.StatusCode != http.StatusOK {
+		defer closeResponse(resp)
+		return nil, httpRespToErrorResponse(resp, bucketName, objectName)
 	}
 
 	return resp.Body, nil

Original file line number	Diff line number	Diff line change
`@@ -68,10 +68,10 @@ func (c *Client) PromptObject(ctx context.Context, bucketName, objectName, promp`
`68`	`68`	`if err != nil {`
`69`	`69`	`return nil, err`
`70`	`70`	`}`
`71`		`- if resp != nil {`
`72`		`- if resp.StatusCode != http.StatusOK {`
`73`		`- return nil, httpRespToErrorResponse(resp, bucketName, objectName)`
`74`		`- }`
	`71`	`+`
	`72`	`+ if resp.StatusCode != http.StatusOK {`
	`73`	`+ defer closeResponse(resp)`
	`74`	`+ return nil, httpRespToErrorResponse(resp, bucketName, objectName)`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`return resp.Body, nil`