fix: in errorHandler make sure to return the correct error #94
+40
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
error-handler
branch
from
807904a to
b365620
Compare
poornas
approved these changes
Sep 29, 2023
|
lint check failed |
error handler currently does not return and has never returned the error back to client application for any in-flight requests that might have failed or canceled. make sure we return errors back to client for even transient in-flight request errors.
harshavardhana
force-pushed
the
error-handler
branch
from
b365620 to
f1859e1
Compare
|
fixes #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error handler currently does not return and has never returned
the error back to the client application for any in-flight requests
that might have failed or canceled.
make sure we return errors back to the client for even transient
in-flight request errors.