-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UsesXml annotation #1245
Comments
I can see how this would be useful for extensions, but for customizing the appearance of built-in components I would prefer that we have a proper editor for letting users manage the layout of items. |
UsesXml should also allow to add custom XML code into AndroidManifest like Compiler.java does. |
Rather than introduce a @SusanRatiLane You should familiarize yourself with Compiler.java before starting this project. |
Hi @SusanRatiLane, |
This is going to be fixed by #3292 |
Yes, I think we need to use a technique similar to adding aar libraries here. Because we need to add an R.txt file and a package for a given library that requires an R.class file. I think the R.txt file must contain predefined identifiers like built-in libraries do. But without it aapt2 also indexes resources correctly. I wonder if we should just create the same R.class file that is created in the main application package, in the library package for which we are adding resources. On the other hand, there is a PR that adds functionality to add resources from an AAR library without additional annotation, but it is outdated now. But we also have to consider that sometimes we need to create a custom xml file that is not associated with any library. Maybe we just need to combine the two techniques. |
This may be required to create custom Resources like listview item layout.
The text was updated successfully, but these errors were encountered: