test: test cases added for validation

Author: marslanabdulrauf

cms/forms.py

@@ -39,6 +39,7 @@ class CoursewareForm(WagtailAdminPageForm):
     Admin form for the Courseware Pages.
 
     This form introduces price and course_run fields to manage product pricing in CMS.
+    And update course dropdown based on the page type.
     """
 
     course_run = forms.ChoiceField(
@@ -59,12 +60,7 @@ def __init__(self, data=None, files=None, parent_page=None, *args, **kwargs):
 
         instance = kwargs.get("instance")
         if instance and instance.is_internal_or_external_course_page:
-            course_qs = Course.objects.all()
-            if instance.is_course_page:
-                course_qs = Course.objects.filter(is_external=False)
-            elif instance.is_external_course_page:
-                course_qs = Course.objects.filter(is_external=True)
-
+            course_qs = Course.objects.filter(is_external=instance.is_external_course_page)
             self.fields["course"].queryset = course_qs
 
         if instance and instance.id:

courses/admin.py

@@ -9,7 +9,6 @@
 from django.forms import TextInput
 
 from mitxpro.admin import AuditableModelAdmin, TimestampedModelAdmin
-from courses.forms import CourseForm
 from mitxpro.utils import get_field_names, now_in_utc
 
 from .models import (
@@ -62,8 +61,6 @@ class CourseAdmin(admin.ModelAdmin):
         models.CharField: {"widget": TextInput(attrs={"size": "80"})}
     }
 
-    form = CourseForm
-
     @admin.display(
         description="Program",
         ordering="program__readable_id",

courses/forms.py

@@ -614,6 +614,37 @@ def available_runs(self, user):
     class Meta:  # noqa: DJ012
         ordering = ("program", "title")
 
+    def clean(self):
+        """
+        Ensures that is_external field is not changed if course is associated with CoursePage or ExternalCoursePage
+        """
+
+        if not self.pk:
+            return
+
+        original = Course.objects.get(pk=self.pk)
+        if original.is_external == self.is_external:
+            return
+
+        if getattr(self, "coursepage", None):
+            raise ValidationError(
+                {
+                    "is_external": (
+                        "Course is associated with CoursePage, cannot change is_external value"
+                    )
+                }
+            )
+        elif getattr(self, "externalcoursepage", None):
+            raise ValidationError(
+                {
+                    "is_external": (
+                        "Course is associated with ExternalCoursePage, cannot change is_external value"
+                    )
+                }
+            )
+
+        return super().clean()
+
     def save(self, *args, **kwargs):  # noqa: DJ012
         """Overridden save method"""
         # If adding a Course to a Program without position specified, set it as the highest position + 1.

courses/models.py

@@ -11,6 +11,7 @@
 from cms.factories import (
     CertificatePageFactory,
     CoursePageFactory,
+    ExternalCoursePageFactory,
     FacultyMembersPageFactory,
     ProgramPageFactory,
 )
@@ -841,3 +842,23 @@ def test_course_language_prevent_delete():
     course_page = CoursePageFactory.create()
     with pytest.raises(ProtectedError):
         course_page.language.delete()
+
+@pytest.mark.parametrize(("is_external", "page_factory"), [(True, ExternalCoursePageFactory), (False, CoursePageFactory)])
+def test_is_external_field_update_after_course_is_attached_with_course_page(is_external, page_factory):
+    """
+    Tests that is_external field is not updated after a course is attached with a course page.
+    """
+    course = CourseFactory.create(is_external=is_external, page=None)
+    page_factory.create(course=course)
+    course.is_external = not is_external
+    with pytest.raises(ValidationError):
+        course.save()
+
+@pytest.mark.parametrize(("is_external"), [True, False])
+def test_is_external_field_update_before_course_is_attached_with_course_page(is_external):
+    """
+    Tests that is_external field is updated bnefore a course is attached with a course page.
+    """
+    course = CourseFactory.create(is_external=is_external, page=None)
+    course.is_external = not is_external
+    course.save()

courses/models_test.py

@@ -33,7 +33,7 @@ def basket_and_coupons():
     """
     Sample basket and coupon
     """
-    basket_item = BasketItemFactory()
+    basket_item = BasketItemFactory(product__content_object__course__page=None)
 
     # Some prices for the basket item product
     ProductVersionFactory(product=basket_item.product, price=Decimal("15.00"))