fix: imports and typo

Author: marslanabdulrauf

cms/forms.py

@@ -54,7 +54,7 @@ def __init__(self, data=None, files=None, parent_page=None, *args, **kwargs):
         1. Adds choices for course_run field.
         2. Update course field queryset based on the page type.
         """
-        from cms.models import Course
+        from courses.models import Course
 
         super().__init__(data, files, parent_page, *args, **kwargs)
 

courses/models.py

@@ -618,6 +618,7 @@ def clean(self):
         """
         Ensures that is_external field is not changed if course is associated with CoursePage or ExternalCoursePage
         """
+        super().clean()
 
         if not self.pk:
             return
@@ -643,8 +644,6 @@ def clean(self):
                 }
             )
 
-        return super().clean()
-
     def save(self, *args, **kwargs):  # noqa: DJ012
         """Overridden save method"""
         # If adding a Course to a Program without position specified, set it as the highest position + 1.

courses/models_test.py

@@ -848,7 +848,7 @@ def test_course_language_prevent_delete():
     ("is_external", "page_factory"),
     [(True, ExternalCoursePageFactory), (False, CoursePageFactory)],
 )
-def test_is_external_field_update_after_course_is_attached_with_course_page(
+def test_prevent_is_external_update_after_course_page_attachment(
     is_external, page_factory
 ):
     """
@@ -862,11 +862,11 @@ def test_is_external_field_update_after_course_is_attached_with_course_page(
 
 
 @pytest.mark.parametrize(("is_external"), [True, False])
-def test_is_external_field_update_before_course_is_attached_with_course_page(
+def test_allow_is_external_update_before_course_page_attachment(
     is_external,
 ):
     """
-    Tests that is_external field is updated bnefore a course is attached with a course page.
+    Tests that is_external field is updated before a course is attached with a course page.
     """
     course = CourseFactory.create(is_external=is_external, page=None)
     course.is_external = not is_external