Fix power to radiance conversion #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Blender 4.x, they at some point fixed their faulty conversion from power to radiance. They had a factor of 4 in that, where it should have been pi instead: https://projects.blender.org/blender/blender/issues/109404
This PR adjusts the exporter to now export according to the new, fixed convention.
Here some validation renderings. It's best to just download these and compare in TEV:
Blender Cycles rendering:
Mitsuba rendering with current exporter:
Mitsuba rendering with fixed exporter:
I think the area light is the only case that is affected. How much is backwards compatibility a consideration here? For full backwards compatibility, we would have to make this scaling conditional on the precise version of Blender where this changed (not sure which one that is)