Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting text with lower case, accents, etc #3

Open
jlin opened this issue Oct 9, 2009 · 3 comments
Open

sorting text with lower case, accents, etc #3

jlin opened this issue Oct 9, 2009 · 3 comments

Comments

@jlin
Copy link

jlin commented Oct 9, 2009

Hello!

I was trying out this code, and I have some text in lowercase, and also with some French accents. The lower case characters were sorted after all the uppercase, and the text with accents appeared even farther below that.

Is this a problem with my set up, or is the default text sorter just doing an ascii sort? or would there be a way to correct this, maybe via a custom sorter?

@jlin
Copy link
Author

jlin commented Oct 10, 2009

I got around this by add in .toLowerCase(); and then running a regex replacement to strip out possible diacritics on vowels and letters in the fallback text conversion function. It's not very elegent, but I don't know much javascript, and it seems to do the trick.

@jlin
Copy link
Author

jlin commented Oct 10, 2009

I guess this is now closed?

@mixonic
Copy link
Owner

mixonic commented Oct 16, 2009

Hey jlin! Do you have a patch anywhere? I agree actually running a comparison on the accented characters would be ideal, and I would have expected it to be built into the normal Javascript comparison.

Let me know if you have a patch, but otherwise I'm going to leave this open until I build a fix.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants