Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_databases fails #18

Open
josephwb opened this issue Apr 9, 2021 · 9 comments
Open

update_databases fails #18

josephwb opened this issue Apr 9, 2021 · 9 comments

Comments

@josephwb
Copy link
Contributor

josephwb commented Apr 9, 2021

I have set my data/localblast.config to point to my database (which it seems to find), but when I try to run the database updater I get the following error:

$ time python3 update_databases.py
Workflow runs with 8 threads.
/home/josephwb/Downloads/PhylUp/blastdb/
./data/nodes.dmp
/home/josephwb/Downloads/PhylUp/blastdb/
Traceback (most recent call last):
  File "update_databases.py", line 11, in <module>
    ncbi_data_parser.Parser(names_file=config.ncbi_parser_names_fn,
AttributeError: module 'PhylUp.config' has no attribute 'ncbi_parser_names_fn'

I cannot figure out what is going wrong. Is it looking for ./data/names.dmp or something else?

@mkandziora
Copy link
Owner

I called by accident the module instead of the conf object. Fixed it - sorry for that.

But there is a problem with the higher blast version now - which has no update_blastdb function anymore - just the perl script which I cannot call from within python. Will work on a fix.

@mkandziora
Copy link
Owner

Ok, looks like it is fixed. Blast version > 2.9 needs update_blastdb.pl instead. It might need some more cpan and json modules for linux installed to get it to run...

@josephwb
Copy link
Contributor Author

josephwb commented Apr 13, 2021

I am still getting the same error. Was this supposed to be fixed?

I have update_blastdb.pl on my system. I was able to update the taxonomy db as described in the wiki, but I have no idea how to update the blast db itself. Could this be added to the wiki? Is it not possible to incorporate this into the PhylUp codebase? Can't perl just be called with os.system("update_blastdb.pl ARGS")?

@mkandziora
Copy link
Owner

You get the same error when running update_databases.py? Did you pull the newest version? It is updating the databases currently on my end.

The update of the blast database will only happen if your database is older than 90 days (made more explicit in the wiki now). Added the update_blastdb.pl nt to the wiki under update.

@mkandziora mkandziora reopened this Apr 13, 2021
@josephwb
Copy link
Contributor Author

josephwb commented Apr 13, 2021

Yes, I have pulled and am up-to-date and still get a similar error:

$ time python3 update_databases.py
Workflow runs with 8 threads.
/home/josephwb/Downloads/PhylUp/blastdb/
./data/nodes.dmp
/home/josephwb/Downloads/PhylUp/blastdb/
Traceback (most recent call last):
  File "update_databases.py", line 16, in <module>
    ncbi_data_parser._download_ncbi_parser(conf)
AttributeError: module 'ncbiTAXONparser.ncbi_data_parser' has no attribute '_download_ncbi_parser'

Is there an additional step I need to do after pulling?

@mkandziora
Copy link
Owner

mkandziora commented Apr 13, 2021

Fixed. Nothing else to do. There was an error in the class assignment - which I did not encounter before.

@josephwb
Copy link
Contributor Author

Eep still not working for me :( Too many arguments?

$ time python3 update_databases.py
Workflow runs with 8 threads.
/home/josephwb/Downloads/PhylUp/blastdb/
./data/nodes.dmp
/home/josephwb/Downloads/PhylUp/blastdb/
Traceback (most recent call last):
  File "update_databases.py", line 16, in <module>
    ncbi_parser._download_ncbi_parser(conf)
TypeError: _download_ncbi_parser() takes 1 positional argument but 2 were given

@josephwb
Copy link
Contributor Author

Do you need further information to diagnose my problem? I cannot see where _download_ncbi_parser is receiving 2 arguments.

@mkandziora
Copy link
Owner

No, sorry for the delay. I was moving to a different place and wanted to make sure things are really working this time. (I havent updated my blast db again - but the rest was working now for me)

@mkandziora mkandziora reopened this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants