Consts / defaults (#45)

* no const on return

* defaulting

Author: PhilipDeegan

README.noformat

@@ -41,7 +41,7 @@ Used by macros KOUT and KLOG : see inc/usage.hpp
 
 Key             KUL_GIT_CO
 Type            string
-Default         ""
+Default         "--depth 10 --recursive --shallow-submodules"
 Description - Add string to git clone as arguments
 
 Key             KUL_SVN_CO

inc/mkn/kul/assert.hpp

@@ -52,7 +52,7 @@ struct Assert {
   }
 };
 
-void abort_if(bool b) {
+void inline abort_if(bool b) {
   if (b) std::abort();
 }
 

inc/mkn/kul/os/nixish/env.hpp

@@ -43,6 +43,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include <algorithm>
 #include <fstream>
 #include <thread>
+#include <cassert>
 
 #include <limits.h>
 
@@ -65,7 +66,13 @@ inline std::string GET(char const* c, std::string default_ = "") {
   char const* r = getenv(c);
   return std::string(r ? r : default_);
 }
-inline void SET(char const* var, char const* val) { setenv(var, val, 1); }
+inline void SET(char const* var, char const* val = nullptr) {
+  assert(var);
+  if (val and strlen(val) > 0)
+    setenv(var, val, 1);
+  else
+    unsetenv(var);
+}
 inline char SEP() { return ':'; }
 
 inline std::string CWD() {

inc/mkn/kul/os/win/env.hpp

@@ -83,8 +83,11 @@ inline std::string GET(char const* c, std::string default_ = "") {
   return default_;
 }
 
-inline void SET(char const* var, char const* val) {
-  _putenv(std::string(std::string(var) + "=" + std::string(val)).c_str());
+inline void SET(char const* var, char const* val = nullptr) {
+  if (val and strlen(val) > 0)
+    _putenv(std::string(std::string(var) + "=" + std::string(val)).c_str());
+  else  // unset
+    _putenv(std::string(std::string(var) + "=").c_str());
 }
 
 inline char SEP() { return ';'; }

inc/mkn/kul/scm.hpp

@@ -117,7 +117,8 @@ class Git : public SCM {
       KTHROW(Exception) override {
     Dir dr(d, true);
     mkn::kul::Process p("git");
-    p << "clone" << mkn::kul::env::GET("KUL_GIT_CO") << r;
+    std::string defaults = "--depth 10 --recursive --shallow-submodules";
+    p << "clone" << mkn::kul::env::GET("KUL_GIT_CO", defaults) << r;
     if (!v.empty()) p.arg("-b").arg(v);
     try {
       p.arg(d).start();

inc/mkn/kul/yaml.hpp

@@ -163,7 +163,7 @@ class File : public Item {
   }
   virtual ~File() {}
   std::string const& file() const { return f; }
-  const virtual Validator validator() const = 0;
+  virtual Validator validator() const = 0;
 
  protected:
   void reload() KTHROW(Exception) {
@@ -178,7 +178,7 @@ class File : public Item {
   File(std::string const& f) KTHROW(Exception) : f(f) { reload(); }
 
  private:
-  const std::string f;  // file
+  std::string const f;  // file
 };
 }  // namespace yaml
 }  // namespace kul