Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SQL conversion #346

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

smuellner
Copy link

Added two converters for SQL inserts and updates

@smuellner smuellner mentioned this pull request Aug 11, 2019
composer.json Outdated Show resolved Hide resolved
@smuellner
Copy link
Author

There have been now some more changes, but overall I feel final to merge back.
The PR now contains a change to the main countries.json introducing a unique id for every country (ucid) to allow for updating the countries in a database.

@mledoze
Copy link
Owner

mledoze commented Sep 2, 2019

Hello, thank you for your work, I will look into it this week.

@smuellner
Copy link
Author

Hello, thank you for your work, I will look into it this week.

Thanks a lot for your work and idea on this repository, it did help me very much with getting a good head start.
If you need changes or input I would be very happy and glad to provide them.
For the necessary change adding a unique country _id, it would be very nice to have your insight if there would be another approach possible instead of using an ordinal number. I did thought about the country code but as this is not provided for all countries it was not a good fit. Any other value seemed to be not constant and subjected to change or it felt not a good fit as a unique database ID at all.

Thanks again and have a great week,
Sascha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants