lintr

pat-s · pat-s · commit a5315f9a29b4 · 2020-11-21T09:05:26.000+01:00
diff --git a/.lintr b/.lintr
@@ -5,5 +5,6 @@ linters: with_defaults(
     object_name_linter = object_name_linter(c("snake_case", "CamelCase")), # only allow snake case and camel case object names
     cyclocomp_linter = NULL, # do not check function complexity
     commented_code_linter = NULL, # allow code in comments
+    todo_comment_linter = NULL,
     line_length_linter = line_length_linter(120)
     )
diff --git a/tests/testthat/test_featsel_filters.R b/tests/testthat/test_featsel_filters.R
@@ -103,7 +103,7 @@ test_that("Custom threshold function for filtering works correctly", {
     fun.args = list("diff" = 1)
   )
   feats = getTaskFeatureNames(ftask)
-  expect_equal(feats, c("Petal.Length"))
+  expect_equal(feats, "Petal.Length")
 })
 
 test_that("randomForestSRC_var.select minimal depth filter returns NA for features below the threshold", {

Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,6 @@ linters: with_defaults(`
`5`	`5`	`object_name_linter = object_name_linter(c("snake_case", "CamelCase")), # only allow snake case and camel case object names`
`6`	`6`	`cyclocomp_linter = NULL, # do not check function complexity`
`7`	`7`	`commented_code_linter = NULL, # allow code in comments`
	`8`	`+ todo_comment_linter = NULL,`
`8`	`9`	`line_length_linter = line_length_linter(120)`
`9`	`10`	`)`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ test_that("Custom threshold function for filtering works correctly", {`
`103`	`103`	`fun.args = list("diff" = 1)`
`104`	`104`	`)`
`105`	`105`	`feats = getTaskFeatureNames(ftask)`
`106`		`- expect_equal(feats, c("Petal.Length"))`
	`106`	`+ expect_equal(feats, "Petal.Length")`
`107`	`107`	`})`
`108`	`108`
`109`	`109`	`test_that("randomForestSRC_var.select minimal depth filter returns NA for features below the threshold", {`