Join threads before deleting to avoid crashing.

mlverse · Nov 5, 2024 · b504d27 · b504d27
1 parent c5c9082
commit b504d27
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/inst/include/utils.h b/inst/include/utils.h
@@ -98,6 +98,12 @@ class ThreadPool {
   void push (std::packaged_task<T()>&& task) {
     this->event_loop.schedule(std::move(task));
   }
+  ~ThreadPool() {
+    this->event_loop.stopWhenEmpty();
+    for(auto& thread : threads) {
+      thread.join();
+    }
+  }
 };
 
 template <class type>

diff --git a/src/autograd.cpp b/src/autograd.cpp
@@ -60,7 +60,6 @@ namespace {
 static EventLoop<void*> gTasks;
 static EventLoop<void> gBackwardTasks;
 static std::atomic<bool> backward_is_running(false);
-//static ThreadPool<void>* pool;
 
 void schedule_backward_task(std::packaged_task<void()>&& task) {
   static ThreadPool<void> pool(5);