Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libtorch 2.5.1 #1204

Merged
merged 57 commits into from
Nov 14, 2024
Merged

Libtorch 2.5.1 #1204

merged 57 commits into from
Nov 14, 2024

Conversation

dfalbel
Copy link
Member

@dfalbel dfalbel commented Oct 31, 2024

Add support for LibTorch 2.5.1

TODO:

  • Update Libtorch M1 builds - and patch the allocator
  • Regenerate R level wrappers
  • Figure out pre-built binaries for x86_64 macOS
  • Drop unsupported CUDA from CI
  • Figure out Windows build issues
  • Support CUDA 12.4
  • Fix crashes related to optional values
  • Fix loading of GenericDicts
  • Figure out windows deadlocks. Probably related to cleaning up the event loop.
  • Figure out failing tests on CUDA:
     -- Failure ('test-distributions-constraints.R:17:3'): positive definite --------
     as_array(object$cpu()) not equal to `expected`.
     10 element mismatches
     Backtrace:
         x
      1. \-torch:::expect_equal_to_r(...) at test-distributions-constraints.R:17:3
      2.   \-testthat::expect_equal(as_array(object$cpu()), expected, ...) at tests/testthat/helper-tensor.R:44:3
    

@dfalbel dfalbel added the lantern Use this label if your PR affects lantern so it's built in the CI label Oct 31, 2024
@dfalbel dfalbel merged commit 2ff1848 into main Nov 14, 2024
17 checks passed
@dfalbel dfalbel deleted the libtorch/v2.5.1 branch November 14, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lantern Use this label if your PR affects lantern so it's built in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants