Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git submodule foreach "(git checkout master; git pull)" not working #2

Closed
lewismc opened this issue Jan 17, 2019 · 4 comments
Closed
Assignees

Comments

@lewismc
Copy link
Member

lewismc commented Jan 17, 2019

Hi @carueda I'm trying to build locally for the first time in a while.
When I execute git submodule foreach "(git checkout master; git pull)"... nothing is happening.
Any ideas?
Thanks

@carueda
Copy link
Member

carueda commented Jan 17, 2019

Hi @lewismc Not sure, it all worked just fine a day or two ago for me when I created that latest version mentioned elsewhere. I think I even reviewed the https://github.com/mmisw/orr/blob/master/README.md

What git version are you using?

@lewismc lewismc self-assigned this Jan 25, 2019
@lewismc
Copy link
Member Author

lewismc commented Jan 25, 2019

What git version are you using?

2.20.1

I had to use git submodule update --init --recursive, I'll send a PR

@carueda
Copy link
Member

carueda commented Jan 25, 2019

ha, you're right. I just tried from scratch.

For starting from the clone operation, the key step is to use the --recursive flag:

git clone --recursive https://github.com/mmisw/orr.git

and this should be added to the README.

With no --recursive is used for the clone, then the step you indicate can be used.

thanks for updating the README.

@carueda carueda reopened this Jan 25, 2019
@carueda
Copy link
Member

carueda commented Jan 28, 2019

Thanks Lewis again for your readme update PR. I just pushed more edits to further clarify the sequence of build steps.

@carueda carueda closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants