-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm install --build-from-source causes large error. #27
Comments
Accidentally closed issue, my apologies. |
I confirm that there is a problem with rebuilding on Windows - but you will also have to rebuild in the Electron environment, this is a Node.js build |
Do you know how I can do this? Thanks. |
Ok, first of all, grab this file: https://github.com/mmomtchev/node-gdal-async/blob/master/deps/libhdf5/hdf5/src/H5version.h and place it in |
Then follow this tutorial: https://www.electronjs.org/docs/latest/tutorial/using-native-node-modules Also, you should know that |
This is the command you need
Run it from |
I have tried to follow your instructions to the best of my understanding. However, this error occurred. :(
Thanks for your continual help. |
Is this everything? Nothing before this? |
|
Which version of Electron are you using? 17? |
By the way, until 3.4.2 gets released, which will be in the next few days, you won't have a choice, you will have to manually add the As far as I am aware, you are the very first Electron user, so expect some rough edges. For now, install normally, then launch the build command in |
I tried the build command here.
|
The error itself is still missing, did you add the |
Is what I'm getting, with adding in \src\H5version.h to the correct location. |
17.1.0 is not supported even by the latest
|
Tried with 17.0.0
|
The actual build error is earlier than this |
This is the whole output.
|
It is still the missing file |
|
Ah, it seems to be in the wrong location. Let me retry. |
It is still failing to execute, the list is too long to copy. |
Try to find the first error |
Attempting the above gives the following error and output (Electron 17.1.0): |
Try
|
Git error? |
😄
This is not a problem on your end - unless it is your ISP or your firewall. Retry. |
I can't get past this error :( |
Can you checkout anything else from Github? This is a network connectivity problem |
Git dep preperation? |
Do you have the latest version of npm?
|
8.5.3 |
Does it work if you build for Node.js? Without setting the other environment variables:
|
I think my SSH to Github is still being refused or timing out. HTTPS connection works, and I've tried replacing the global URLs to use HTTPS. However still getting Git connection error. :/ |
According to the Github status page, all services are up and running, but I am having issues with codecov, so it is possible that something might be failing on their side. I am able to build it with this command both on Linux and Windows. There was a GDAL 3.4.2rc2 yesterday, it will probably get promoted to final tomorrow and I will release 3.4.2 with the missing file |
Thanks so much. Will that allow me to just do |
You will still have to rebuild in the Electron environment - this step is unavoidable for any Node.js addon which has a binary part - unless I ship prebuilt binaries for every Electron release and every platform out there. I am shipping prebuilt binaries for 3 OSes and 4 Node.js versions and this is already a lot - Electron will add three to four times more 😄 I suggest you probably try first Electron 16.x, since Electron 17 is very recent and most build tools do not support it at the moment - then when you know it works, you can try upgrading to 17. |
@tris-g, I just published |
|
Can you try both? First, for Node.js, without any env values - so that we can be sure your environment is set ok, and then for Electron with the env values? |
For Node.js without env values set. |
Here is your problem: https://stackoverflow.com/questions/3898287/c-include-atlbase-h-is-not-found |
Okay that worked without any errors and I can see it using |
With env variables set for Electron build following error: |
Alas, this is an issue between Electron and nan : nodejs/nan#892 I will check if something can be done |
I am closing this issue since this problem has been solved, I created a new issue for Electron |
Thanks for your effort on this @mmomtchev :) |
Is there anything I can do about the nan issue or am I stuck? |
Not on Windows, there is a very important API call which is missing on Electron - I am checking with them to see why - but from what I saw, other module authors reimplemented it themselves and it has been like this for the last 6 months or so. |
Hi there, thanks for responding to my issue on Stack Overflow (https://stackoverflow.com/questions/71383334/how-to-use-node-gdal-with-electron/)
When trying to get gdal-async working in Electron and using
npm install --build-from-source gdal-async
the following happens (please refer to log file).2022-03-07T15_56_59_053Z-debug.log
Thanks.
The text was updated successfully, but these errors were encountered: