Add min, max where appropriate. #3651
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
reviewed
Feb 28, 2025
| @@ -440,7 +442,8 @@ \subsection{Numeric Functions and Conversion Operators}\label{numeric-functions- | |||
| \end{tabular} | |||
| \end{center} | |||
|
|
|||
| All of these except for the \lstinline!String! conversion operator are vectorizable according to \cref{scalar-functions-applied-to-array-arguments}. | |||
| Except for the \lstinline!min!, \lstinline!max! and the \lstinline!String! conversion operator they are vectorizable according to \cref{scalar-functions-applied-to-array-arguments}. | |||
| The \lstinline!min! and \lstinline!max! functions including additional variants are described in \cref{reduction-functions-and-operators}. | |||
There was a problem hiding this comment.
I find including additional variants a bit unclear, could it be reformulated?
There was a problem hiding this comment.
Suggestion: The \lstinline!min! and \lstinline!max! functions have array-specific variants which perform array reduction operations described in ...
henrikt-ma
reviewed
Feb 28, 2025
Comment on lines
+434
to
+435
| {\lstinline!min($x$, $y$)!} & Least of two scalars & \Cref{modelica:min-binary} \\ | ||
| {\lstinline!max($x$, $y$)!} & Greatest of two scalars & \Cref{modelica:max-binary} \\ |
There was a problem hiding this comment.
Similar to the entries above:
Suggested change
| {\lstinline!min($x$, $y$)!} & Least of two scalars & \Cref{modelica:min-binary} \\ | |
| {\lstinline!max($x$, $y$)!} & Greatest of two scalars & \Cref{modelica:max-binary} \\ | |
| {\lstinline!min($x$, $y$)!} & Least of two scalars (event-free) & \Cref{modelica:min-binary} \\ | |
| {\lstinline!max($x$, $y$)!} & Greatest of two scalars (event-free) & \Cref{modelica:max-binary} \\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3650
I'm not sure if using the table in this way is ideal, if not I could see us adding a short description in chapter 3.7 forwarding to the other variant. I don't think that moving those two variants, and duplicating the actual definition would be bad.