Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelicaTest.Electrical.QuasiStatic.*.FrequencySweep is missing experiment annotation #4510

Closed
maltelenz opened this issue Dec 12, 2024 · 1 comment · Fixed by #4516
Closed

ModelicaTest.Electrical.QuasiStatic.*.FrequencySweep is missing experiment annotation #4510

maltelenz opened this issue Dec 12, 2024 · 1 comment · Fixed by #4516
Assignees
@casella
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Milestone
MSL4.1.0

Comments

@maltelenz
Copy link
Contributor

The models:

ModelicaTest.Electrical.QuasiStatic.Polyphase.FrequencySweep
ModelicaTest.Electrical.QuasiStatic.SinglePhase.FrequencySweep

are missing an experiment annotation, assuming they are meant to be tested.
@maltelenz maltelenz added this to the MSL4.1.0 milestone Dec 12, 2024
@maltelenz maltelenz changed the title ModelicaTest.Electrical.QuasiStatic.Polyphase.FrequencySweep is missing experiment annotation ModelicaTest.Electrical.QuasiStatic.*.FrequencySweep is missing experiment annotation Dec 12, 2024
@beutlich beutlich added the L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined label Dec 12, 2024
casella added a commit to casella/ModelicaStandardLibrary that referenced this issue Jan 7, 2025
@casella
Added missing experiment annotations. Fixes modelica#4510
d7787b6
@casella casella mentioned this issue Jan 7, 2025
Merged
@casella
Copy link
Contributor

casella commented Jan 7, 2025 •
edited
Loading

I checked

Both files contents are consistent with StopTime = 1.0 and Interval = 0.0002.

Should be fixed by #4516, which adds the annotations accordingly.

@casella casella self-assigned this Jan 7, 2025
casella added a commit that referenced this issue Jan 21, 2025
@casella @HansOlsson
Add missing experiment annotations (#4516)
ff95fea 
* Added missing experiment annotations. Fixes #4510

* Update ModelicaTest/Electrical/QuasiStatic/Polyphase.mo

Co-authored-by: Hans Olsson <[email protected]>

* Update ModelicaTest/Electrical/QuasiStatic/SinglePhase.mo

Co-authored-by: Hans Olsson <[email protected]>

---------

Co-authored-by: Hans Olsson <[email protected]>
maltelenz pushed a commit to maltelenz/ModelicaStandardLibrary that referenced this issue Jan 21, 2025
@casella @maltelenz
Add missing experiment annotations (modelica#4516)
4b0b69c 
* Added missing experiment annotations. Fixes modelica#4510

* Update ModelicaTest/Electrical/QuasiStatic/Polyphase.mo

Co-authored-by: Hans Olsson <[email protected]>

* Update ModelicaTest/Electrical/QuasiStatic/SinglePhase.mo

Co-authored-by: Hans Olsson <[email protected]>

---------

Co-authored-by: Hans Olsson <[email protected]>
(cherry picked from commit ff95fea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casella casella

Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging a pull request may close this issue.

Add missing experiment annotations casella/ModelicaStandardLibrary
3 participants
@maltelenz @casella @beutlich