Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DataFrame.__setitem__ on empty frame switches engines #7428

Open
3 tasks done
sfc-gh-mvashishtha opened this issue Jan 27, 2025 · 0 comments
Open
3 tasks done

BUG: DataFrame.__setitem__ on empty frame switches engines #7428

sfc-gh-mvashishtha opened this issue Jan 27, 2025 · 0 comments
Labels
bug 🦗 Something isn't working

Comments

@sfc-gh-mvashishtha
Copy link
Contributor

sfc-gh-mvashishtha commented Jan 27, 2025

Modin version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest released version of Modin.

  • I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example

import modin.pandas as pd
import pandas
from modin.config import StorageFormat, Engine
from modin.core.storage_formats.pandas.query_compiler import PandasQueryCompiler
from modin.config import NativeDataframeMode


StorageFormat.put('Pandas')
Engine.put('Python')
python_df = pd.DataFrame()
assert isinstance(python_df._query_compiler, PandasQueryCompiler)
NativeDataframeMode.put('Pandas')
native_execution_series = pd.Series([1, 2, 3])
assert not isinstance(native_execution_series._query_compiler, PandasQueryCompiler)
NativeDataframeMode.put('Default')
python_df['new_value'] = native_execution_series
assert isinstance(python_df._query_compiler, PandasQueryCompiler)

Issue Description

DataFrame.__setitem__ switches the current frame's engine to the inserted value's query compiler's engine.

See #7427 for context: we want to track execution at a per-frame level.

Expected Behavior

We should preserve engine.

Error Logs

N/A

Installed Versions

INSTALLED VERSIONS

commit : 02515bb
python : 3.9.21
python-bits : 64
OS : Darwin
OS-release : 24.2.0
Version : Darwin Kernel Version 24.2.0: Fri Dec 6 18:56:34 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6020
machine : arm64
processor : arm
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8

Modin dependencies

modin : 0.32.0+9.g02515bb8
ray : 2.40.0
dask : 2024.8.0
distributed : 2024.8.0

pandas dependencies

pandas : 2.2.3
numpy : 2.0.2
pytz : 2024.2
dateutil : 2.8.2
pip : 24.2
Cython : None
sphinx : 7.4.7
IPython : 8.18.1
adbc-driver-postgresql: None
adbc-driver-sqlite : None
bs4 : 4.12.3
blosc : None
bottleneck : None
dataframe-api-compat : None
fastparquet : 2024.11.0
fsspec : 2024.12.0
html5lib : None
hypothesis : None
gcsfs : None
jinja2 : 3.1.5
lxml.etree : 5.3.0
matplotlib : 3.9.4
numba : None
numexpr : 2.10.2
odfpy : None
openpyxl : 3.1.5
pandas_gbq : 0.26.1
psycopg2 : 2.9.10
pymysql : None
pyarrow : 19.0.0
pyreadstat : None
pytest : 8.3.4
python-calamine : None
pyxlsb : None
s3fs : 2024.12.0
scipy : 1.13.1
sqlalchemy : 2.0.37
tables : N/A
tabulate : None
xarray : 2024.7.0
xlrd : 2.0.1
xlsxwriter : None
zstandard : None
tzdata : 2024.2
qtpy : None
pyqt5 : None

@sfc-gh-mvashishtha sfc-gh-mvashishtha added the bug 🦗 Something isn't working label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant