(fix) remove all use of ondialogaccept/ondialogcancel

Author: Ludovic Marcotte

TODO

@@ -1,6 +1,5 @@
 see: https://developer.thunderbird.net/add-ons/updates/tb68
 
 - document startup.js
-- review all usage of ondialogaccept
 - review common-card-overlay.js for menulist's editable
 - remove progressmeter and statusbar/statusbarpanel

chrome/content/sogo-connector/addressbook/preferences.addressbook.groupdav.js

@@ -207,10 +207,6 @@ function onShowRestart() {
 
 //TODO:catch the directory delete and delete preferences
 
-function onCancel() {
-    window.close();
-}
-
 // From SOGo Integrator
 var folderURL = "";
 var originalName = "";
@@ -277,3 +273,6 @@ renameTarget.prototype = {
 	}
 };
 
+document.addEventListener("dialogaccept", function(event) {
+  onOverlayAccept();
+});

chrome/content/sogo-connector/addressbook/preferences.addressbook.groupdav.xul

@@ -69,9 +69,7 @@ Modifications by
   xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
   title="&newDirectoryTitle.label;"
   onload="onLoad();"
-  buttons="accept,cancel"
-  ondialogaccept="return onOverlayAccept();"
-  ondialogcancel="return onCancel();">
+  buttons="accept,cancel">
 
   <script type="application/x-javascript" src="chrome://sogo-connector/content/addressbook/preferences.addressbook.groupdav.js"/>
   <!--	<script type="application/x-javascript" src="chrome://sogo-connector/content/addressbook/preference.service.addressbook.groupdav.js"/>

chrome/content/sogo-connector/calendar/properties-overlay.xul

@@ -19,8 +19,7 @@
   <stringbundle id="propertiesMessages" src="chrome://sogo-connector/locale/calendar/properties-overlay.properties"/>
   <script type="application/x-javascript" src="chrome://sogo-connector/content/calendar/properties-overlay.js"/>
 
-  <dialog id="calendar-properties-dialog-2"
-    ondialogaccept="return onOverlayAccept();">
+  <dialog id="calendar-properties-dialog-2">
 
     <vbox id="sogo-calendar-properties" collapsed="true">
       <checkbox id="sogo-notify-on-personal-modifications"

chrome/content/sogo-connector/messenger/update-dialog.js

@@ -115,17 +115,12 @@ function restartIfPossible() {
     }
 }
 
-function onAcceptClick() {
+function onAcceptClick(event) {
     var appStartup = iCc["@mozilla.org/toolkit/app-startup;1"]
                      .getService(iCi.nsIAppStartup);
     appStartup.quit(iCi.nsIAppStartup.eRestart
                     | iCi.nsIAppStartup.eAttemptQuit);
-
-    return false;
-}
-
-function onCancelClick() {
-    return false;
+    event.preventDefault();
 }
 
 function updateDialogOnReload() {
@@ -156,6 +151,10 @@ function updateDialogOnLoad () {
             window.opener.deferredCheckFolders();
         window.close();
     }
+
+    document.addEventListener("dialogaccept", function(event) {
+            onAcceptClick(event);
+        });
 }
 
 window.addEventListener("load", updateDialogOnLoad, false);

chrome/content/sogo-connector/messenger/update-dialog.xul

@@ -17,8 +17,7 @@
 ]>
 
 <dialog xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
-  id="inverseMessengerUpdateDlg" ondialogaccept="return onAcceptClick();"
-  ondialogcancel="return onCancelClick();"
+  id="inverseMessengerUpdateDlg"
   width="380px" height="130px" buttons="accept"
   title="&sogo-connector.title;">
   <script type="application/x-javascript"