Unexpected token in expression

[survuvi]

What's happen?

fn your_function(x: Int) -> StringRef:

    var result: StringRef = "value"

    if x == 0:
        return zero()
    
    elif x > 0 and x < 9:
        result = "small"
        return result

    else:
        result = "big"
        return result
    
    print(return)

fn zero() -> StringRef:
    var result: StringRef = "zero"
    return result

your_function(5)

error: Expression [26]:20:11: unexpected token in expression
print(return)

[DayDun]

You probably want to write print(result) instead of print(return). return is a reserved keyword, so can't be used as a variable name.

[DayDun]

Also the print will never actually run, because all previous branches in the if-statement return beforehand.

warning: Expression [3]:20:11: unreachable code after if statement with then/else that do not fall through
    print(result)
          ^

[survuvi]

fn your_function(x: Int) -> StringRef:

    var result: StringRef
    
    if x == 0:
        zero()
    
    elif x > 0 and x < 9:
        result = "small"
        return result

    else:
        result = "big"
        return result
    
fn zero() -> StringRef:
    
    var result: StringRef = "zero"

    return result
    
print(your_function(5))

_warning: Expression [14]:10:13: 'StringRef' value is unused
zero()
~~~~^~
_ =

error: Expression [15]:5:1: return expected at end of function with results
fn your_function(x: Int) -> StringRef:_

I also tried String instead of StringRef but without success:

from String import String

fn your_function(x: Int):

    var result: String = "value"
    
    if x == 0:
        zero()
    
    elif x > 0 and x < 9:
        result = "small"
        return result

    else:
        result = "big"
        return result
    
fn zero():
    
    var result: String = "zero"

    return result
    
print(your_function(5))

_error: Expression [21]:15:16: 'String' value cannot be converted to 'None' in return value
return result
^~~~~~

error: Expression [21]:19:16: 'String' value cannot be converted to 'None' in return value
return result
^~~~~~

error: Expression [21]:25:12: 'String' value cannot be converted to 'None' in return value
return result
^~~~~~_

[DayDun]

Now you removed the return from the first branch. This means the function won't return anything if x == 0, but it must return a string to match the function signature.

[lattner]

Yep, agreed, I think the compiler is behaving correctly here:

x.🔥:26:11: error: unexpected token in expression
    print(return)
          ^

[survuvi]

Yeah, now it works, thank you

fn your_function(x: Int) -> StringRef:

    var result: StringRef = "value"
    
    if x == 0:
        return zero()
    
    elif x > 0 and x < 9:
        result = "small"
        return result

    else:
        result = "big"
        return result
    
fn zero() -> StringRef:
    
    let result: StringRef = "zero"

    return result
    
print(your_function(5))

or

from String import String

fn your_function(x: Int) -> String:

    var result: String = "value"
    
    if x == 0:
        return zero()
    
    elif x > 0 and x < 9:
        result = "small"
        return result

    else:
        result = "big"
        return result
    
fn zero() -> String:
    
    let result: String = "zero"

    return result
    
print(your_function(10))