Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Remove String StringRef dependencies #3870

Closed
wants to merge 6 commits into from
Closed

[stdlib] Remove String StringRef dependencies #3870

wants to merge 6 commits into from

Conversation

martinvuyk
Copy link
Contributor

Remove String StringRef dependencies

@martinvuyk martinvuyk requested a review from a team as a code owner December 11, 2024 19:41
JoeLoser
JoeLoser approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Dec 13, 2024
@JoeLoser
Copy link
Collaborator

!sync

@ConnorGray ConnorGray self-assigned this Jan 13, 2025
@skongum02 skongum02 deleted the branch modular:main January 29, 2025 18:59
@skongum02 skongum02 closed this Jan 29, 2025
@skongum02 skongum02 reopened this Jan 29, 2025
@skongum02 skongum02 changed the base branch from nightly to main January 29, 2025 20:37
@soraros
Copy link
Contributor

soraros commented Feb 3, 2025

Do we still need this?

@martinvuyk
Copy link
Contributor Author

@soraros didn't see the edited lines after merging, seems like @lsh already merged the changes I was doing here

@martinvuyk martinvuyk closed this Feb 3, 2025
@martinvuyk martinvuyk deleted the remove-string-stringref-dependencies branch February 3, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

Assignees

@ConnorGray ConnorGray

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@martinvuyk @JoeLoser @soraros @ConnorGray @skongum02 @modularbot