Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SvelteKit dev build is not working #206

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

RobinBomkamp
Copy link
Contributor

@RobinBomkamp RobinBomkamp commented Dec 2, 2024

fixes: #163

@gioboa
Copy link
Collaborator

gioboa commented Dec 2, 2024

Thanks @RobinBomkamp for opening this PR, I'll test this code against my SvelteKit POC and that I will merge it if it's working fine.

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect @RobinBomkamp
I tested it and it works 👏
you rock 💪

@gioboa gioboa merged commit 4e6898f into module-federation:main Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteKit: 'SyntaxError: Cannot use import statement outside a module'
2 participants