3.1.1 - Adding new User fails to save once Password Method is changed

[deJaya]

Issue seemingly introduced in 3.1.1-pl

When adding a new user and changing the Password Method to anything other than "Let MODX generate a password" - the radio button for "Show the new password on screen" becomes unchecked.

In this state, saving the user is unsuccessful - but no notification is presented on screen so it feels like save was successful.

Checking the "Show the new password on screen" radio button solves the issue.

Since "Show the new password on screen" is the only option under "Password notification method" - it should always remain checked.

It could be argued that it could be removed, depending on what future plans there are for this section.

Environment

MODX 3.1.1-pl
Tested in 3.1.0-pl and the radio does not become unchecked.

[deJaya]

Issue is also present when editing a user.

[halftrainedharry]

I guess this issue is related to the change introduced with #16668

It looks like when the radio button is unchecked, no value is submitted for the field "passwordnotifymethod", which then generates an error here in the validation:

revolution/core/src/Revolution/Processors/Security/User/Validation.php

Lines 89 to 92 in f279675

	$passwordNotifyMethod = $this->processor->getProperty('passwordnotifymethod', null);
	if (empty($passwordNotifyMethod)) {
	$this->processor->addFieldError('password_notify_method', $this->modx->lexicon('user_err_not_specified_notification_method'));
	}

I'm not sure, if these 4 lines of code are even necessary or could just be deleted.

@smg6511 Can you maybe take a look at this issue?

[smg6511]

Taking a look...

[smg6511]

Ok, easy enough to fix. The PR I put up simply corrects the basic issue. I do agree that the "Show the new password on screen" field is of little to no use. There are some changes I have in mind that would improve this area, but that's better done in another PR.