Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functions when unit testing moved elsewhere #67

Open
pbbgss opened this issue Jan 14, 2025 · 0 comments
Open

New functions when unit testing moved elsewhere #67

pbbgss opened this issue Jan 14, 2025 · 0 comments
Assignees

Comments

@pbbgss
Copy link
Contributor

pbbgss commented Jan 14, 2025

The existing functions were designed with the unit testing section in mind and a more complicated than they need to be for just demonstrating how to assemble a package.

I propose we replace them with simplified versions of is_friday() and glue_year_months(). These function should be easy to understand (thus document), have only two dependencies {stringr} and {lubridate} and would remove the need to cover the data/ s3 interactions in section 1.

In section 16 the "update" would be to add another function is_monday() which is almost identical to is_friday() so people should be able to adapt the tests.

@pbbgss pbbgss self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant