Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way anchor points are removed #22

Open
Friksel opened this issue Jun 23, 2018 · 3 comments
Open

Improve the way anchor points are removed #22

Friksel opened this issue Jun 23, 2018 · 3 comments
Labels
feature feature request to implement optimization optimization request

Comments

@Friksel
Copy link

Friksel commented Jun 23, 2018

  1. In the README it says alt + d to remove an anchor point. Working on Windows in Chrome this isn't working here. After selecting an editor and an anchor point on the curve the point is not deleted with alt + d. Neither with ctrl + d or shift + d. Am I missing something, or is this an issue?

  2. In most graphical software I use deleting anchor points happens with the DEL-key. Could this shortcut be added as an additional keyboard shortcut? To me that would be a lot more descriptive and intuitive then a double keystroke for something we use a lot.

  3. It would be nice to have a delete-button in the curve-editor interface too. Working with a lot of different software it's hard to remember all different shortcuts and keys aren't always the prefered way to me. Having a key to remove an anchor point would not only be convenient for graphical use, but could also show the shortcut key on the tooltip, so you get to know the shortcut after use more often. Instead of having to go to the github readme.

That said, very impressive workflow like this and beautiful layout of both the curve editor as the player. Thanks a lot for all the effort you obviously put into all of this! It's a lot of fun using mo.js! I like it a lot. Keep up the great work! :)

@Friksel Friksel changed the title remove anchor point is not working? + remove anchor button + delete key? [1.5.0] remove anchor point is not working? + remove anchor button + delete key? Jun 23, 2018
@xavierfoucrier xavierfoucrier added the feature feature request to implement label Apr 12, 2019
@Sandstedt
Copy link
Member

  1. Need to to some browser testing. It works fine on Firefox 67 on a Mac at least.

2 and 3. Good ideas. We'll add it in the backlog.

@xavierfoucrier xavierfoucrier changed the title [1.5.0] remove anchor point is not working? + remove anchor button + delete key? Improve the way anchor points are removed Jan 15, 2021
@xavierfoucrier xavierfoucrier added the optimization optimization request label Jan 15, 2021
@skymen
Copy link

skymen commented Mar 10, 2021

In some browsers, alt+d selects the URL and thus it seems to be breaking the delete point code.
I am on Windows 10 + Chrome 88

@xavierfoucrier
Copy link
Member

Hi @skymen,

Yes we know there is some issues with current shortcuts on the player.
We need to refactor them. Thanks for giving your feedback on this 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature request to implement optimization optimization request
Projects
None yet
Development

No branches or pull requests

4 participants