running tests: plugin crash (SEE IF UPGRADING TO V5.6+ FIXES THIS) #17
Comments
|
Hi igpit, sorry the plugin's crashing for you! I've installed JsonTools version 3.6.1.1 on Notepad++ 8.4.6 and when I run the tests, I don't get a crash, and the tests that fail are the ones I expect to fail. This happened when my setup was exactly the same as yours (including installed plugins) except the following differences: Since I can't replicate the bug, I'm not sure if I can help, but maybe you could share a picture of what tests passed and failed up until the crash? |
|
Happens also to me with stacktrace: and exception |
|
Notepad++ v8.4.6 (64-bit) Testresults: |
|
Hi chcg and igpit, thanks for getting back to me! I think I see what one of the problems is at least for chcg: I forgot to specify the decimal separator in my tests, so all the tests that use floating point numbers are going to fail until I manually set the decimal separator in the tests. I'm honestly not sure whether it is even a good idea to allow the parsing of JSON that uses a decimal separator other than I think once I add some code throughout my plugin specifying the decimal separator wherever appropriate, that should fix most of these bugs. It occurs to me that I could try to come up with some way to support |
|
@molsonkiko Likely that is caused by the language\country setup used, because in german |
|
Tried changing my system decimal settings to |
|
sry for the late response. yes, used windows is german. i just re-tested with JsonTools 4.1 on NPP 8.4.6. Now it fails with a new error message: Also this is the output i get in NPP: |
|
@molsonkiko I see the same failures as reported by @igpit with release 4.1. |
|
Based on the fact that the failure happens during the In the future I will either make it so that the test files are included along with the DLL in my plugin, or remove those tests. |
ADDED
1. About form, containing information about the plugin.
FIXED
1. Test files (the testfiles directory) are now included along
with the DLL. This should address #17 in which the plugin
crashed while running the JSON grepper tests.
|
With the current version I get the first exception at: and there are following much more. The question is if they are intented/normal or real problems. |
|
Hi @chcg , the best way to determine whether the errors are expected or not is to compare the output to "most recent errors.txt". Unfortunately, I'm skeptical of my ability to fix any issues where something fails on your machine that doesn't fail on mine. The tests are run from TestRunner.cs. |
|
with the latest v4.2 when doing "Run Tests" i get a empty text file, no error popup. then, with whatever even the smallest json test files i open, i tried "pretty print JSON" or "JSON Tree Viewer", i always get
|
molsonkiko
added
the
maintainer can't replicate
|
In the probably-related issue #16, ctidrv said
Anybody else having this issue: try upgrading to release 5.6, or better yet, the latest release. Please let me know if upgrading to v5.6+ doesn't fix it. |
molsonkiko
added
the
probably fixed?
molsonkiko
changed the title
select "Run Tests" from plugin menu
JsonTools.dll just crashed in
runPluginCommand(size_t i : 19)
Notepad++ v8.4.6 (64-bit)
Build time : Sep 25 2022 - 19:51:39
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 10 Pro (64-bit)
OS Version : 21H2
OS Build : 19044.2006
Current ANSI codepage : 1252
Plugins :
HtmlTag (1.3.5)
JsonTools (3.6.1.1)
MimeTools (2.8)
NppConverter (4.4)
NppExport (0.4)
UrlPlugin (1.2)
XMLTools (3.1.1.13)
The text was updated successfully, but these errors were encountered: