task: go tools (#3875)

Author: gssbzn

.github/workflows/autoupdate-sdk.yaml

@@ -15,7 +15,6 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version-file: 'go.mod'
-      - run:  go install github.com/icholy/gomajor@latest
       - id:   version
         run:  echo "VERSION=$(curl -sSfL -X GET  https://api.github.com/repos/mongodb/atlas-sdk-go/releases/latest | jq -r '.tag_name')" >> "$GITHUB_OUTPUT"
       - run:  make update-atlas-sdk

.github/workflows/code-health.yml

@@ -311,7 +311,6 @@ jobs:
         uses: actions/setup-go@v5
         with:
           go-version-file: 'go.mod'
-      - run: make devtools
       - run: ./build/ci/check-licenses.sh
   checktemplates:
     name: checktemplates

Makefile

@@ -68,12 +68,7 @@ deps:  ## Download go module dependencies
 .PHONY: devtools
 devtools:  ## Install dev tools
 	@echo "==> Installing dev tools..."
-	go install github.com/google/addlicense@latest
 	go install go.uber.org/mock/mockgen@latest
-	go install golang.org/x/tools/cmd/goimports@latest
-	go install github.com/google/go-licenses@latest
-	go install mvdan.cc/sh/v3/cmd/shfmt@latest
-	go install github.com/icholy/gomajor@latest
 	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin $(GOLANGCI_VERSION)
 
 .PHONY: setup
@@ -87,12 +82,7 @@ link-git-hooks: ## Install git hooks
 
 .PHONY: fmt
 fmt: ## Format changed go
-	@scripts/fmt.sh
-
-.PHONY: fmt-all
-fmt-all: ### Format all go files with goimports and gofmt
-	find . -name "*.go" -not -path "./vendor/*" -not -path "./internal/mocks" -exec gofmt -w "{}" \;
-	find . -name "*.go" -not -path "./vendor/*" -not -path "./internal/mocks" -exec goimports -l -w "{}" \;
+	golangci-lint fmt
 
 .PHONY: test
 test: unit-test

build/ci/check-licenses.sh

@@ -27,5 +27,5 @@ find_files() {
 }
 
 for FILE in $(find_files); do
-	addlicense -c "MongoDB Inc" -check "${FILE}"
+	go tool addlicense -c "MongoDB Inc" -check "${FILE}"
 done

build/ci/library_owners.json

@@ -48,7 +48,6 @@
 	"go.opentelemetry.io/otel/sdk": "apix-2",
 	"go.opentelemetry.io/otel/trace": "apix-2",
 	"go.uber.org/mock": "apix-2",
-	"golang.org/x/exp": "apix-2",
 	"golang.org/x/mod": "apix-2",
 	"golang.org/x/net": "apix-2",
 	"golang.org/x/sys": "apix-2",

build/package/generate-notices.sh

@@ -16,8 +16,6 @@
 
 set -Eeou pipefail
 
-go install github.com/google/go-licenses@latest
-
-go-licenses save "github.com/mongodb/mongodb-atlas-cli/atlascli/cmd/atlas" --save_path=third_party_notices
+go tool go-licenses save "github.com/mongodb/mongodb-atlas-cli/atlascli/cmd/atlas" --save_path=third_party_notices
 # For HCL, a dependency of viper, go-license adds the source code with restricted permissions, this is a problem for some linux users
 sudo chmod -R 755 ./third_party_notices

go.mod

@@ -20,7 +20,7 @@ require (
 	github.com/briandowns/spinner v1.23.2
 	github.com/creack/pty v1.1.24
 	github.com/denisbrodbeck/machineid v1.0.1
-	github.com/evergreen-ci/shrub v0.0.0-20241002130202-d2f0f3752474
+	github.com/evergreen-ci/shrub v0.0.0-20250506131348-39cf0eb2b3dc
 	github.com/getkin/kin-openapi v0.132.0
 	github.com/go-test/deep v1.1.1
 	github.com/golang-jwt/jwt/v5 v5.2.2
@@ -51,7 +51,6 @@ require (
 	go.opentelemetry.io/otel/sdk v1.35.0
 	go.opentelemetry.io/otel/trace v1.35.0
 	go.uber.org/mock v0.5.2
-	golang.org/x/exp v0.0.0-20241004190924-225e2abe05e6
 	golang.org/x/mod v0.24.0
 	golang.org/x/net v0.40.0
 	golang.org/x/sys v0.33.0
@@ -62,6 +61,28 @@ require (
 	gopkg.in/yaml.v3 v3.0.1
 )
 
+require (
+	github.com/bmatcuk/doublestar/v4 v4.0.2 // indirect
+	github.com/emirpasic/gods v1.12.0 // indirect
+	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
+	github.com/google/addlicense v1.1.1 // indirect
+	github.com/google/go-licenses v1.6.0 // indirect
+	github.com/google/licenseclassifier v0.0.0-20210722185704-3043a050f148 // indirect
+	github.com/icholy/gomajor v0.14.0 // indirect
+	github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
+	github.com/kevinburke/ssh_config v0.0.0-20190725054713-01f96b0aa0cd // indirect
+	github.com/mitchellh/go-homedir v1.1.0 // indirect
+	github.com/otiai10/copy v1.6.0 // indirect
+	github.com/sergi/go-diff v1.2.0 // indirect
+	github.com/src-d/gcfg v1.4.0 // indirect
+	github.com/xanzy/ssh-agent v0.2.1 // indirect
+	go.opencensus.io v0.24.0 // indirect
+	gopkg.in/src-d/go-billy.v4 v4.3.2 // indirect
+	gopkg.in/src-d/go-git.v4 v4.13.1 // indirect
+	gopkg.in/warnings.v0 v0.1.2 // indirect
+	k8s.io/klog/v2 v2.80.1 // indirect
+)
+
 require (
 	cloud.google.com/go v0.120.0 // indirect
 	cloud.google.com/go/auth v0.16.1 // indirect
@@ -169,3 +190,9 @@ require (
 	google.golang.org/genproto/googleapis/api v0.0.0-20250414145226-207652e42e2e // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20250425173222-7b384671a197 // indirect
 )
+
+tool (
+	github.com/google/addlicense
+	github.com/google/go-licenses
+	github.com/icholy/gomajor
+)