Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore course with course fullname #6

Open
JochenBN opened this issue Apr 16, 2019 · 1 comment
Open

Restore course with course fullname #6

JochenBN opened this issue Apr 16, 2019 · 1 comment

Comments

@JochenBN
Copy link

Hello from Bonn in Germany.

Maybe we found a bug in restoring courses.
If we restore a course via sandbox the fullname of the course does not get reset.
The course will keep its fullname.

Is it a bug or isnt it possible to restore the fullname?

Regards
Jochen

@abias
Copy link
Member

abias commented May 29, 2019

Hi Jochen,

thanks for raising this issue.

In https://github.com/moodleuulm/moodle-local_sandbox/blob/master/classes/task/restore_courses.php#L82, local_sandbox picks the fullname of the course which is scheduled to be reset, and on https://github.com/moodleuulm/moodle-local_sandbox/blob/master/classes/task/restore_courses.php#L189, it sets this fullname to the resetted course. This means that the fullname of the course backup file is overwritten with the fullname of the pre-existing course.

For us, this is expected behavior as our users are not allowed to change the course names. Only admins are able to change course names.

However, I agree that in setups where teachers can change course names, this behavior can be considered as bug.

The solution would be to create an admin setting similar to the existing "Keep course ID" setting which controls if the resetted course will have the fullname from the pre-existing course or from the course backup file.

I will keep this issue in our backlog. But due to a lack of resources, we probably won't be able to realize this setting anytime soon.

Cheers,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants