Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File support? #53

Open
mattporritt opened this issue Apr 28, 2021 · 2 comments
Open

File support? #53

mattporritt opened this issue Apr 28, 2021 · 2 comments

Comments

@mattporritt
Copy link

Hi Ulm Team,
Has there been any thought for being able to add file support to this plugin? So uploaded static pages could have files?

One way I though of doing was, having an upload area for "static assets", so things like images, pdf docs, etc. That would then would be handled by Moodles file API. These files would then be referenced by relative path and file name in the upload html file.

For example if I had an image tag, like: When the page is rendered this would be replaced (maybe by a filter) to https://mysitet/pluginfile.php/123/local_staticpage/content/background.jpg

Sorry if this has been asked before.

Cheers,
Matt P

@christianwolters
Copy link
Member

Hi @mattporritt,

this is not in the scope of this plugin, atm - see: https://github.com/moodleuulm/moodle-local_staticpage#adding-images-to-static-pages

Cheers
Christian

@abias
Copy link
Member

abias commented Aug 28, 2021

Hi @mattporritt ,

thanks for asking for this feature.

While @christianwolters is right pointing to the plugin's README file, I think your proposed implementation could be valueable to some admins.

If you want to come up with a pull request for such a static assets area including a proper explanation how to use it in the README file (to avoid too much support questions being asked), that would be great.

Cheers,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants