Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibilitysupport_form button should be labeled with "send" #830

Open
whuml opened this issue Feb 18, 2025 · 1 comment · May be fixed by #854
Open

accessibilitysupport_form button should be labeled with "send" #830

whuml opened this issue Feb 18, 2025 · 1 comment · May be fixed by #854
Assignees
Labels
good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@whuml
Copy link
Collaborator

whuml commented Feb 18, 2025

Improvement of accessibility support form
Some Boost Union Users noticed wrong meaning of button label "submit":

accessibilitysupport_form:
$this->add_action_buttons(true, get_string('submit'));
german translation: "submit" usually is translated as "speichern"

But should be translated here as: "senden"

Describe alternatives you've considered
As translation should be adjusted only for accessibilitysupport_form it might be necessary to implement ?

$this->add_action_buttons(true, get_string('send', 'theme_boost_union'));
"send" translated as "senden"

@whuml whuml added the new Something which has been reported but has not yet beeen triaged by the team label Feb 18, 2025
@abias abias added good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) and removed new Something which has been reported but has not yet beeen triaged by the team labels Mar 9, 2025
@abias abias moved this to In Progress DEV in Boost Union Planning Board Mar 9, 2025
@abias abias self-assigned this Mar 9, 2025
@abias
Copy link
Member

abias commented Mar 9, 2025

Hi @whuml ,

while the button's label is currently the same as the button label on the Moodle core support form on /user/contactsitesupport.php and while I think that the english term "submit" is fine, I agree with you that the german translation in the general Moodle language pack "Speichern" is not really helpful in this particular case.

I will change the form in a way that it uses a Boost Union specific string which can then be translated in AMOS as "Senden".

Cheers,
Alex

abias added a commit that referenced this issue Mar 9, 2025
… used in the accessbility support form which allows better translatons, resolves #830.
@abias abias moved this from In Progress DEV to In Progress REVIEW in Boost Union Planning Board Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Status: In Progress REVIEW
2 participants