When running tests with the "chrome:latest" browser and VNC port the outdated -debug image is used

[marinaglancy]

In this commit cb73fdd we no longer use selenium/standalone-chrome-debug image for the newer versions of chrome. However we still use it with the "latest" version

Example:

MOODLE_DOCKER_BROWSER="chrome:latest"
MOODLE_DOCKER_SELENIUM_VNC_PORT=""

uses the image selenium/standalone-chrome:latest

However

MOODLE_DOCKER_BROWSER="chrome:latest"
MOODLE_DOCKER_SELENIUM_VNC_PORT=1234

uses the image selenium/standalone-chrome-debug:latest which is some older version :(

[marinaglancy]

ping @NoelDeMartin - I'm not sure which issue this commit is related to and where I should comment about it

[NoelDeMartin]

I added that in #281, when I realized that starting in version 4 selenium images don't use the -debug suffix anymore. However, looking at the code I don't understand how using a different VNC port changes that if :/. I guess someone would have to debug it, but TLDR the suffix should only be used for selenium versions previous to 4.0. And seeing that the last -debug release came out 3 years ago, maybe you can remove it altogether.

[marinaglancy]

hi @NoelDeMartin , this is the code

if [[ $(echo $MOODLE_DOCKER_BROWSER_TAG | sed 's/[^0-9].*//g') -lt 4 ]]
    then
        export MOODLE_DOCKER_SELENIUM_SUFFIX="-debug"
    fi

this means that if MOODLE_DOCKER_BROWSER_TAG=latest, the -debug suffix is added. It took me half a day to figure out why I can't reproduce the problem that ci.moodle.org finds locally