Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.toggle-on ul not triggering block property for dropdown menu #3

Open
da5id5 opened this issue Apr 20, 2017 · 2 comments
Open

.toggle-on ul not triggering block property for dropdown menu #3

da5id5 opened this issue Apr 20, 2017 · 2 comments

Comments

@da5id5
Copy link

da5id5 commented Apr 20, 2017

/* Toggle small menu and children on */
.toggled-on ul,
.sub-menu.toggled-on {
display: block;
}

not sure if _s or wp update broke this...

@frontenddevguy
Copy link

That should say .children.toggled-on and is incorrectly specified as .sub-menu.toggled-on as far as the branch I am currently at (06_05).

navigation.js specifies both:
_this.next( '.children, .sub-menu' ).toggleClass( 'toggled-on' );

It could be an _s update to class_walker..
This requires that we are merging in our local changes :)

@Jessicaraethomsen
Copy link

Thanks for the answer, frontenddevguy! We had the same mistake. Just to clarify.
Step 1: Go to: Header-menu.scss
Step 2: Find: .sub-menu.toggled-on
Step 3 Change to: .children.toggled-on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants