Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

striped stored series compiles code excessively #266

Open
kthielen opened this issue Mar 12, 2019 · 0 comments
Open

striped stored series compiles code excessively #266

kthielen opened this issue Mar 12, 2019 · 0 comments

Comments

@kthielen
Copy link
Contributor

The logic as currently implemented looks like this:

    void record(const K& k, const void* v, bool signal = true) {
      auto d = this->dmap.find(k);
      if (d != this->dmap.end()) {
        d->second->record(v, signal);
      } else {
        auto* s = new StoredSeries(this->c, this->db, 0, this->vty, this->bsize, this->sm);
        this->pmap.insert(k, s->rootRef());
        this->dmap[k] = s;
        s->record(v, signal);
      }
    }

This results in one compile phase per unique key, but nothing unique is compiled in each case and instead the compile step can be factored out and done once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant