Skip to content

Commit

Permalink
Resolve issue with children map not being updated correctly when chil…
Browse files Browse the repository at this point in the history
…d scoped destroyed (#74)

* Resolve issue with children map not being updated correctly when child scoped destroyed

* Update package versions accordingly.

* Add new typescript target for testing
  • Loading branch information
Davidhanson90 authored Aug 22, 2023
1 parent 3cadbf0 commit 42a9d58
Show file tree
Hide file tree
Showing 5 changed files with 489 additions and 389 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
typescript-version: [4.2, 4.3, 4.4, 4.5, 4.6, 4.7, 4.8, 4.9]
typescript-version: [4.2, 4.3, 4.4, 4.5, 4.6, 4.7, 4.8, 4.9, 5.0]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion main/core/injector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class Injector implements IInjector {
* Creates a new map from our internal child maps
*/
public get children(): Map<InjectorIdentifier, IInjector> {
return new Map(this._children);
return this._children;
}

/**
Expand Down
Loading

0 comments on commit 42a9d58

Please sign in to comment.