-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v4.3.0 release #212
Comments
Sounds good to me, I'll look into the Windows bundle |
Awesome! We can use SNT-v4.3.0-pre-release1 (mapped to 746b1d2) as a freeze point. It includes some minor improvements I had laying around on stalled branches, and more recent work I needed: tweaks to auto-tracing and Weka integration:
|
@tferr when I try to open Rec. Viewer, I get this error on Windows 11
According to https://jogamp.org/wiki/index.php?title=Maven , the native libraries for all platforms are included with the following maven dependencies <dependencies>
<dependency>
<groupId>org.jogamp.gluegen</groupId>
<artifactId>gluegen-rt-main</artifactId>
<version>2.3.2</version>
</dependency>
<dependency>
<groupId>org.jogamp.jogl</groupId>
<artifactId>jogl-all-main</artifactId>
<version>2.3.2</version>
</dependency>
</dependencies> I tested it in 8c9d5f3 and it seems to work. |
Bummer and weird. That 2.3.2 is the last official version from 2015(!). If I recall correctly, there was patched 2.4.0 version released earlier last year that was pushed to Maven by Jzy3D. I think Curtis worked on that so that our parent scijava pom would use that instead. My understanding is that the 2.4.0 version is the one currently in use by Fiji (JDK8) on all platforms. I predict downgrading it may cause conflicts elsewhere!? Shall we bring this up on Zulip? |
I see, yeah we should definitely bring this up |
@carshadi , are you able to test Curtis's suggestion: https://imagesc.zulipchat.com/#narrow/stream/327238-Fiji/topic/Problems.20with.20JOGL.20dependencies.20on.20Windows.2011/near/413230673? |
This works for me |
Curtis' fix added: Let's target https://github.com/morphonets/SNT/releases/tag/SNT-v4.3.0-pre-release2 (21ea56b) |
Hello Tiago, I'd like to update the Scijava pom and get rid of the exclusions about |
Hi @elect86, BUILD FAILURE
|
Would you mind if I give it a try myself? |
Not at all, go ahead! Do you need anything from me? |
so far no |
may I update to the latest Scijava pom 38.0.0-SNAPSHOT? |
Sure!
…On Thu, Mar 14, 2024, 11:46 Giuseppe Barbieri ***@***.***> wrote:
may I update to the latest Scijava pom 38.0.0-SNAPSHOT?
—
Reply to this email directly, view it on GitHub
<#212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASTWDBFTGHVDOAN2QMRGQLYYHA3VAVCNFSM6AAAAABA7ANWFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXG43DIMBRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Could you add me to the repo so that I can create a new branch and work from there instead of forking? |
Which tests are supposed to pass with Maven? Because I'm getting weird errors on my machine Otherwise what passes so far with Gradle is this |
@elect86, just sent you the invite. let me know if it something else is needed.
The tests that call |
Hm, not really. I had convinced myself all tests were passing with 3293439. Will need to look, but I'm in meeting all day. Won't be able to look into it immediately |
they all have |
Anyway, if you want I can publish If yes, shall I upgrade the pom-scijava to I just realized now it's a cyclic dep.. |
Sure go ahead. bumping it to |
SNT and the POM |
Published, thanks for your availability Tiago! |
Awesome! Did you end up pushing something here? I don't seem to notice any new commits... |
In the meanwhile I was waiting for a reply I got eager to try and start working on the fork, then I though I changed the back the remote once I got the invite, but apparently I didn't, it's all here I can push to a |
Pushed here as well |
The next release (v4.3.0) has major changes, notably: minimum Java11 requirement, several changes to auto-tracing and path refining, plus a whole slew of bug-fixes/patches/tweaks. I suspect somethings may break, and it would be useful to plan ahead. Things that we should do:
Create Fiji bundles with SNT compiled from main branch + the new launcher + OpenJDK11. We can post those here, so that folks can report issues more easily. I doubt the bulk of users is able/willing to grab the binaries themselves. I can do it for ubuntu (and maybe MacOS) (@carshadi are you able to do this for WIndows OS?)NB: It may just be easier to just use Make Fiji Package!?
Givin up on this, since jaunch is eminient
1121 release)@carshadi, agree? comments?
The text was updated successfully, but these errors were encountered: