feature: support set extension for dump file #130
Conversation
|
Hi @almas1992, welcome to mosn community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
mosn-community-bot
bot
added
cla:no
First-time contributor
size/M
cla:yes
and removed
cla:no
labels
|
@almas1992 Thanks for your contribution, please fix the code style issue, refer: https://github.com/mosn/holmes/pull/130/files#diff-f0067949ae0f48685cd310e00ccaf0c72d02048ccc6aeb0a862cd30b81e5e566 Also, please add doc in README, thanks. |
These code style issue you mentioned are not brought about by my PR，I just add one value 不知道是我没表达清楚还是，你所说的代码风格问题，即有两个未使用变量不是我这次提交引入的，所以我也不太好直接去除，还希望作者自行定夺 |
|
Removed unused variables to fixed code style issue and upgrade github.com/shirou/gopsutil version to fix |
| @@ -604,8 +612,9 @@ golang.org/x/sys v0.0.0-20201009025420-dfb3f7c4e634/go.mod h1:h1NjWce9XRLGQEsW7w | |||
| golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | |||
| golang.org/x/sys v0.0.0-20201214210602-f9fddec55a1e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | |||
| golang.org/x/sys v0.0.0-20201223074533-0d417f636930/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | |||
| golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e h1:WUoyKPm6nCo1BnNUvPGnFG3T5DUVem42yDJZZ4CNxMA= | |||
There was a problem hiding this comment.
seems this change leads to the CI failure, since the CI use go1.14.
https://github.com/mosn/holmes/actions/runs/3573887532/jobs/6020361017
# golang.org/x/sys/unix
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall.go:83:16: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_linux.go:2256:9: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
|
just close it. |
fix #4