Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks (achievements ?) #16

Open
moul opened this issue Aug 29, 2013 · 4 comments
Open

Add hooks (achievements ?) #16

moul opened this issue Aug 29, 2013 · 4 comments
Milestone

Comments

@moul
Copy link
Owner

moul commented Aug 29, 2013

No description provided.

@moul moul added Experiment and removed Features labels Feb 5, 2014
@ccharlton
Copy link

Is there an existing library you'd use to support this?

@moul
Copy link
Owner Author

moul commented Jun 4, 2015

Hum, I really don't know, actually I only thought about hooks for achievements (kind of https://github.com/icefox/git-achievements), but hooks may unlock some useful workflows

We need to think about which kind of hooks may be useful, for instance, something like:

  • on_pre_ssh_connection(host, port)
  • on_after_ssh_connection(host, port, pid?)
  • on_ssh_connection_closed(host, port, duration, exitCode)
  • on_error(host, port, errcode)

About the library specifically I have no preferences, just keep in mind I'm thinking about porting this project in golang to enhance speed, ease of install and recode everything from zero to fix some hacks I did in the Python version, I will probably keep the 2 versions for a time so people can keep their preferred one (#35)

@ccharlton
Copy link

Cute. Don't forget one for when writing a config file with ASSH for the first time. :)

@moul moul self-assigned this Sep 7, 2015
@moul moul added Ideas and removed Experiment labels Sep 7, 2015
@moul moul added this to the Proposal milestone Mar 21, 2016
@moul moul modified the milestones: Proposal, v2.5.0 Jul 14, 2016
@moul
Copy link
Owner Author

moul commented Aug 10, 2016

hooks are implemented, achievements aren't yet

@moul moul added the ready label Dec 6, 2016
@moul moul modified the milestones: v2.5.0, v2.6.0 Jan 5, 2017
@moul moul modified the milestones: v2.6.0, v2.7.0 Feb 3, 2017
@moul moul removed their assignment Sep 18, 2017
@moul moul modified the milestones: v2.7.0, v2 ✌ Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants