Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export moveit_py_utils' cmake target(s) #2207

Merged
merged 1 commit into from
May 29, 2023

Conversation

rhaschke
Copy link
Contributor

To use moveit_py_utils in downstream projects (e.g. MTC), its targets need to be exported.

@rhaschke rhaschke requested a review from peterdavidfagan May 29, 2023 10:13
@JafarAbdi
Copy link
Member

Should we move it to a separate package outside this repo? I needed the same utilities for PickNikRobotics/rviz_visual_tools#239 and my solution was to copy past them

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ea784f) 50.51% compared to head (3dc60a0) 50.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2207   +/-   ##
=======================================
  Coverage   50.51%   50.51%           
=======================================
  Files         386      386           
  Lines       31736    31736           
=======================================
  Hits        16028    16028           
  Misses      15708    15708           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rhaschke
Copy link
Contributor Author

Should we move it to a separate package outside this repo?

Of course, we could provide a MoveIt-independent utility package for python bindings. I thought about this too already.
However, for simplicity, I always decided to stick with a moveit package. In any case, that's a different decision.
For now, we should make moveit_py reusable by downstream packages.

I needed the same utilities for PickNikRobotics/rviz_visual_tools#239 and my solution was to copy past them.

I'm always trying to avoid duplicating code!

@rhaschke rhaschke merged commit 5fea33d into moveit:main May 29, 2023
@rhaschke rhaschke deleted the export-moveit-py branch May 29, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants