-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle GitHub repositories that moved #134
Comments
I think the entry is updated in bugsahoy to |
Bad example, I forgot I had updated that (and I guess you imported from bugsahoy before my update). mozilla-releng/services (moved to mozilla/release-services) is a good example. |
I don't know how Github handles those redirects in general. It seems that whatever API bugsahoy used "followed" the redirects, whereas the GraphQL API codetribute uses does not. It may be that we just need to keep the YAML files up to date? |
Interesting -- if you use API v3 (REST), you get a 301 with info on the new location, both in the HTTP headers and the JSON response. With API v4 (GraphQL), you only get a 404 :( fwiw, I opened a ticket on GitHub's GraphQL support forum. |
Looks like no support for detecting renames in GraphQL (no action on ticket) Up to the frontend infra team how they want to handle this case, imo. One way to minimize ongoing breakage would be to restrict use of this tool to repositories already in a Mozilla owned org. |
Or maybe we can add a sentence in the README in the Github section that they need to keep their repository org and name up to date as Dustin previously suggested? |
Maybe some kind of nightly job that queries all of the repositories and checks that they still resolve would be the easiest way to deal with this. |
There are some GitHub repositories I moved from my personal account to the Mozilla org (e.g. marco-c/grcov -> mozilla/grcov).
The issues from those repos don't show up in codetribute (they do show up in bugsahoy).
The text was updated successfully, but these errors were encountered: