Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to select which lints run #34

Open
2 of 3 tasks
agi90 opened this issue Nov 29, 2018 · 0 comments
Open
2 of 3 tasks

Add a way to select which lints run #34

agi90 opened this issue Nov 29, 2018 · 0 comments
Assignees
@agi90
Labels
enhancement New feature or request

Comments

@agi90
Copy link
Contributor

agi90 commented Nov 29, 2018 •
edited
Loading

We need a way to select the lints that run as some of them are very specific to some applications.

Some wanted features:

  • Select list of lints that run (right now everything runs) or maybe a blacklist
  • Select list of lints that run and fail the build (right now none of the lints do this)
  • Have a whitelist for classes that fail the lint

We can probably have a apilint.json configuration file somewhere to store all of those.
@agi90 agi90 mentioned this issue Nov 29, 2018
Merged
@agi90 agi90 added the enhancement New feature or request label Nov 29, 2018
agi90 pushed a commit to agi90/gradle-apilint that referenced this issue Nov 30, 2018
@agi
Issue mozilla-mobile#34: Add a way to filter errors.
c4c6a48
agi90 pushed a commit that referenced this issue Dec 5, 2018
@agi @agi90
Issue #34: Add a way to filter errors.
3f20f44
agi90 pushed a commit to agi90/gradle-apilint that referenced this issue Dec 5, 2018
@agi
Issue mozilla-mobile#34: Add a way to enforce specific lints.
ebc7a1e 
Before this commits no lints would actually fail the build because we only
checked for compatibility.

After this commit apilint runs the lint twice:

- Once with only the existing api as argument to check for lints (with an
  optional filter for lints).

- Once with both existing and new API to check for compatibility.

This adds a new configuration: `apiLint.lintFilters` which allows consumers to
set a list of prefixes of lints that can fail the build.
@agi90 agi90 self-assigned this Dec 5, 2018
agi90 pushed a commit that referenced this issue Dec 10, 2018
@agi @agi90
Issue #34: Add a way to enforce specific lints.
835d4e3 
Before this commits no lints would actually fail the build because we only
checked for compatibility.

After this commit apilint runs the lint twice:

- Once with only the existing api as argument to check for lints (with an
  optional filter for lints).

- Once with both existing and new API to check for compatibility.

This adds a new configuration: `apiLint.lintFilters` which allows consumers to
set a list of prefixes of lints that can fail the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agi90 agi90

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agi90