Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are part of methods identity #38

Open
agi90 opened this issue Dec 5, 2018 · 0 comments
Open

Annotations are part of methods identity #38

agi90 opened this issue Dec 5, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@agi90
Copy link
Contributor

agi90 commented Dec 5, 2018

Annotations are part of methods identity in apilint, which causes apilint to not recognize when annotations are added or removed and instead causing apilint to think that the method has been removed giving a confusing error.

E.g. apilint gives this error:

Error: Method removed or incompatible change
    in method public org.mozilla.geckoview.GeckoResult<org.mozilla.gecko.util.GeckoBundle> getSnapshots(boolean)
    in public final class RuntimeTelemetry
    in package org.mozilla.geckoview
    at line 846

for this change

   public final class RuntimeTelemetry {
-    method public org.mozilla.geckoview.GeckoResult<org.mozilla.gecko.util.GeckoBundle> getSnapshots(boolean);
+    method @android.support.annotation.AnyThread public org.mozilla.geckoview.GeckoResult<org.mozilla.gecko.util.GeckoBundle> getSnapshots(boolean);
   }

While really what we would want is "Annotation added" which should probably not be a compat issue.

@agi90 agi90 added the bug Something isn't working label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant