Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use digest_size instead of hardcoded value #134

Open
boolean5 opened this issue May 21, 2020 · 0 comments
Open

Use digest_size instead of hardcoded value #134

boolean5 opened this issue May 21, 2020 · 0 comments
Assignees
@boolean5
Labels
enhancement good first bug p3 Backlog

Comments

@boolean5
Copy link
Contributor

In lists2safebrowsing.py the size of sha256 hashes is hardcoded to 32 bytes in several places, when we could be using hash.digest_size to get it. The result would obviously be the same, but it would be a small improvement in terms of readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boolean5 boolean5

Labels
enhancement good first bug p3 Backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boolean5 @HarshitSohaney